httping: fix build on < 10.11 #25943
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reneeotten
reviewed
Sep 27, 2024
| port:gettext | ||
|
|
||
| depends_lib-append port:fftw-3 \ | ||
| port:gettext-runtime \ |
There was a problem hiding this comment.
you are changing the depends_lib dependencies so that requires to increase the revision
reneeotten
reviewed
Sep 27, 2024
|
|
||
| installs_libs no | ||
|
|
||
| patchfiles patch-tcp.c.diff | ||
|
|
||
| # https://trac.macports.org/ticket/70146 | ||
| # https://github.com/folkertvanheusden/HTTPing/pull/22 | ||
| patchfiles-append 0001-Define-NO_TFO-on-macOS-10.11.patch |
There was a problem hiding this comment.
let's wait and see what the outcome is from the discussion with upstream as we don't want to carry patched like this.
|
ping @barracuda156 please fix or close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://trac.macports.org/ticket/70146
Description
Fix
Type(s)
Tested on
macOS 10.6
Xcode 3.2
Verification
Have you
port lint --nitpick?sudo port test?sudo port -vst install?